Add dir and repl-opts to the cljs-task #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows setting the :output-dir for code compiled on the cljs repl (e.g. when require-ing a namespace) and other cljs repl options. fixes adzerk-oss#36
|
This simple approach won't work because we can't trust that target dir exists. Users might not even have any target dir etc. Proper solution is to somehow (fileset metadata) publish the temp-dir used by boot-cljs so we can use that here. |
|
@Deraen Any updates on this since? Will try this workaround but wondering if this was fixed or there is another workaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extended the
cljs-repltask to allow setting the:output-dirfor code compiled on the CLJS REPL (e.g. whenrequire-ing a namespace) and other CLJS REPL options. This fixes #36 and #32, the former really annoying me as I couldn't simply(require 'cljs.pprint)on the repl.Unfortunately, I was not able to find an automated way of getting the current target dir and compilation file (I'm using the new
targettask in my setup), so I settled on an option to the to set the REPLs:output-dirmanually. It defaults to"target/main.out", which will work with the setup that I copied from theboot-cljs-example-repo.